[ome-devel] Scanr patch

[Rubén Muñoz]

Hi Melissa,

That's a good point, actually we still need it. 
I certainly forgot to recalculate this value. What about?:

int nSpot = well * nPos + pos + 1;
names[realPosCount] = "Well " + (well + 1) + ", Field " + (pos +1) + " (Spot " + nSpot + ")";

The code doesn't label non-acquired wells.

Best,
Rubén

On Sep 16, 2010, at 11:58 PM, Melissa Linkert wrote:

> Hi Rubén,
> 
> Applying this patch is not a problem, but I just want to verify that the
> format of the Image names is correct.
> 
> In a previous thread, you had asked to have the spot number included in
> the Image name (as is currently being done).  See:
> 
> http://lists.openmicroscopy.org.uk/pipermail/ome-devel/2009-December/001536.html
> http://lists.openmicroscopy.org.uk/pipermail/ome-devel/2009-December/001538.html
> 
> Are you sure that the spot number should be removed from the Image name?
> 
> Regards,
> -Melissa
> 
> On Thu, Sep 16, 2010 at 09:47:45AM +0200, Rubén Muñoz wrote:
>> Hi Melissa, 
>> 
>> After using the ScanR importer with some non-captured wells, I realized that the names were incorrect.
>> I did the following patch to fix the problem. 
>> 
>> This is not preventing the converter to create more metadata and images than actually needed, but is already a help.
>> 
>> Thanks!
>> 
>> Rubén
>> 
>> 337a338,339
>>>    String [] names = new String [nWells * nPos];
>>> 
>> 361a364
>>>                  names[realPosCount] = "Well " + (well + 1) + ", Field " + (pos +1);
>> 468,470c471
>> <       String name = "Well " + (well + 1) + ", Field " + (field +1) + " (Spot " +
>> <         (i + 1) + ")";
>> <       store.setImageName(name, i);
>> ---
>>>      store.setImageName(names[i], i);