<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
Dear Torsten,
<div class=""><br class="">
</div>
<div class="">thank you very much for your contribution. The proposed changes look reasonable.</div>
<div class=""><br class="">
</div>
<div class="">At this point, feel free to turn your patch directly into a Pull Request against the Bio-Formats</div>
<div class="">source code [1]. We are happy to do it on your behalf if you prefer.</div>
<div class=""><br class="">
</div>
<div class="">We will also add the sample file you uploaded to our data repository for non-regression testing.</div>
<div class="">Ideally we would like to make this sample file public under the CC-BY 4.0 license [2] so that the</div>
<div class="">community can re-use it for future development of the library (see [3] for an example). Would that</div>
<div class="">be acceptable?</div>
<div class=""><br class="">
</div>
<div class="">Best,</div>
<div class="">Sebastien</div>
<div class=""><br class="">
</div>
<div class="">[1] <a href="https://github.com/openmicroscopy/bioformats/blob/develop/CONTRIBUTING.md" class="">
https://github.com/openmicroscopy/bioformats/blob/develop/CONTRIBUTING.md</a></div>
<div class="">[2] <a href="http://creativecommons.org/licenses/by/4.0" class="">http://creativecommons.org/licenses/by/4.0</a> </div>
<div class="">[3] <a href="http://downloads.openmicroscopy.org/images/ND2/aryeh/" class="">http://downloads.openmicroscopy.org/images/ND2/aryeh/</a> </div>
<div class=""><br class="">
<div>
<blockquote type="cite" class="">
<div class="">On 31 Jan 2017, at 13:04, Torsten Stöter <<a href="mailto:torsten.stoeter@lin-magdeburg.de" class="">torsten.stoeter@lin-magdeburg.de</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">Dear OME developers,<br class="">
<br class="">
I'd like to submit a tiny patch to allow reading different versions of ECAT7 files.<br class="">
<br class="">
It appears, that ECAT7 comes in three versions with differing magic strings "MATRIX7[012]v", while the rest of the file may just be handled in the same way for all versions. Manually modifying the magic string from "MATRIX70v" to "MATRIX72v" in our data allowed
us to load it correctly. Hence, I changed the ECAT7Reader to accept all three magic strings as valid ECAT7 files.<br class="">
<br class="">
For referecence, see how ECAT7 is read in SPM: <a href="https://github.com/neurodebian/spm12/blob/master/spm_ecat2nifti.m" class="">
https://github.com/neurodebian/spm12/blob/master/spm_ecat2nifti.m</a><br class="">
<br class="">
Please find both patch and sample data attached.<br class="">
<br class="">
Best regards<br class="">
<br class="">
Torsten Stöter<br class="">
<br class="">
-- <br class="">
Torsten Stöter<br class="">
Leibniz Institute for Neurobiology<br class="">
Brenneckestr. 6<br class="">
39118 Magdeburg<br class="">
Germany<br class="">
<br class="">
Tel: ++49 (0)391 62639-2171<br class="">
Fax: ++49 (0)391 62639-2589<br class="">
<a href="http://www.lin-magdeburg.de/cni" class="">http://www.lin-magdeburg.de/cni</a><br class="">
<br class="">
<span id="cid:8AAF2B0E-09AB-44EB-9CFC-E7CD0124B2FB"><Ecat7Reader.java.diff></span><span id="cid:FCE87007-16FE-458C-836B-EFE86DC96CD2"><ecat7-ver70-testfile.v.7z></span>_______________________________________________<br class="">
ome-devel mailing list<br class="">
ome-devel@lists.openmicroscopy.org.uk<br class="">
http://lists.openmicroscopy.org.uk/mailman/listinfo/ome-devel<br class="">
</div>
</blockquote>
</div>
<br class="">
</div>
<br>
<span style="font-size:10pt;">The University of Dundee is a registered Scottish Charity, No: SC015096</span>
</body>
</html>