<div dir="ltr">Continuing discussion on devteam:<br><div><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 16 June 2014 16:10, Chris Allan <span dir="ltr"><<a href="mailto:callan@glencoesoftware.com" target="_blank">callan@glencoesoftware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Douglas,<br>
<br>
Happy to take this to ome-devel if that's useful for you.<br>
<div class=""><br>
On 12 Jun 2014, at 23:57, Douglas Russell <<a href="mailto:douglas.russell@bioch.ox.ac.uk">douglas.russell@bioch.ox.ac.uk</a>> wrote:<br>
<br>
> Hi Chris,<br>
><br>
> I've just been testing your jstree improvements and it looks great. Just wondering if there is interest in taking this further? I've already extended tree.py to handle images and tags so far for the purposes of my customized containers_tree but also for container_subtree. If revamping more of the tree is desired then I can PR some/all of that work into the main codebase.<br>
<br>
</div>There's definitely universal need to extend tree.py and that API to all uses of the tree. Especially tags. Any and all help there appreciated.<br></blockquote><div><br></div><div>Ok, cool. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class=""><br>
><br>
> If I do submit it, I'm unsure on if it's appropriate to build in the capabilities I need for my jstree integrated tagsearching directly into the marshalling code?<br>
><br>
> <a href="https://github.com/dpwrussell/webtagging/blob/jstree_speedup_tags_as_filter/tagsearch/tree.py" target="_blank">https://github.com/dpwrussell/webtagging/blob/jstree_speedup_tags_as_filter/tagsearch/tree.py</a><br>
><br>
> E.g.<br>
><br>
> def marshal_images(conn, experimenter_id=None, dataset_id=None, tag_filter=None):<br>
<br>
</div>I think we can discuss that on a case by case basis to be honest. What I don't really want to get in to is trying to be all things to all people with this API. If we all agree it's generally useful though all the better.<br>
</blockquote><div><br></div><div>Agreed. One thing which I think is worth considering is powering the jstree with JSON instead of HTML. 2 possible ways to do that.</div><div><br></div><div>1) Define the appropriate django views to return JSON as determined by the jstree spec. The highest performing solution, but these views are all but useless for anything else.<br>
</div><div>2) Convert the marshalled data to JSON and return that. These views can be reused anywhere that these structures are useful. Downside is that the ajax success function of the jstree ajax call will have to take this JSON and convert it into the expected format.</div>
<div> </div><div>As you say, (2) may be trying to be all things to all people.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class=""><br>
><br>
> This can get and marshal all images, a filtered set of images by dataset and/or a filtered set of images by a number of tags.<br>
><br>
> It's not complete as there is some stuff from manager I have yet to investigate; namely containers_icon, especially with relation to load_pixels. I don't foresee any major challenges there though.<br>
<br>
</div>Understood.<br>
<br>
><br>
> Thoughts welcome,<br>
><br>
> Cheers,<br>
><br>
> Douglas<br>
<span class="HOEnZb"><font color="#888888"><br>
-Chris</font></span></blockquote><div><br></div><div>Douglas </div></div><br></div></div>